8000 bpo-23325: Turn signal.SIG_DFL and signal.SIG_IGN into functions. by serhiy-storchaka · Pull Request #8920 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-23325: Turn signal.SIG_DFL and signal.SIG_IGN into functions. #8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

bpo-23325: Turn signal.SIG_DFL and signal.SIG_IGN into functions. #8920

wants to merge 3 commits into from

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Aug 25, 2018 •
edited by bedevere-bot
Loading

These singletons are no longer integers.
They are now copyable and pickleable and have docstrings.

https://bugs.python.org/issue23325

@serhiy-storchaka
bpo-23325: Turn signal.SIG_DFL and signal.SIG_IGN into functions.
3378e99 
These singletons are no longer integers.
They are now copyable and pickleable and have docstrings.
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 25, 2018
@pppery
Copy link
pppery commented Aug 31, 2018 •
edited
Loading

Why should SIG_IGN raise an error when called instead of doing nothing, which is what happens when SIG_IGN is actually supplied as a signal handler?

@serhiy-storchaka
Copy link
Member Author

Why should SIG_IGN raise an error when called instead of doing nothing, which is what happens when SIG_IGN is actually supplied as a signal handler?

Because currently calling SIG_IGN() raises a TypeError. But I agree, we can make it callable.

@chancez chancez mentioned this pull request Feb 22, 2021
Closed
@pitrou
Copy link
Member
pitrou commented Mar 4, 2021

Hmm, the problem is this will break code such as:

handler = signal.getsignal(signum)
if callable(handler):
   # Do something, e.g. call the handler

iritkatriel
iritkatriel requested changes Nov 24, 2022
View reviewed changes
Copy link
Member
@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
@encukou
Copy link
Member
encukou commented Mar 25, 2024

Victor closed the issue, so I'll close the PR too.
They can be reopened together.

@encukou encukou closed this Mar 25, 2024
@serhiy-storchaka serhiy-storchaka deleted the signal-std-handlers branch March 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

Assignees
No one assigned
Labels
awaiting changes type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@serhiy-storchaka @pppery @pitrou @bedevere-bot @encukou @iritkatriel @the-knights-who-say-ni @ezio-melotti
0