8000 bpo-33089: Multidimensional math.hypot() by rhettinger · Pull Request #8474 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-33089: Multidimensional math.hypot() #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 28, 2018
Merged

bpo-33089: Multidimensional math.hypot() #8474

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ec15283
Segfaulting rough draft without NaN support or raising Overflow
rhettinger Jul 7, 2018
abce2b0
Working verion. Double pass over input tuple. No inf/nan handling.
rhettinger Jul 7, 2018
241932e
Simplify. Remove unnecessary second error check. Remove n<=1 special …
rhettinger Jul 7, 2018
51c52fc
Add some tests
rhettinger Jul 24, 2018
de3c16b
Add support for special values.
rhettinger Jul 25, 2018
18babd4
Test scaling for large values
rhettinger Jul 25, 2018
6c412d2
Add tests for small values
rhettinger Jul 26, 2018
780024b
Neaten-up test cases
rhettinger Jul 26, 2018
d82df99
Use module level constants for float min/max
rhettinger Jul 26, 2018
1a32ac7
Expand range for large value tests
rhettinger Jul 26, 2018
82a12e5
Improve variable name
rhettinger Jul 26, 2018
2d2e3aa
Replace the existing hypot() code
rhettinger Jul 26, 2018
6edd323
Clean stray whitespace
rhettinger Jul 26, 2018
9c25c65
Write the docstring
rhettinger Jul 26, 2018
c4dfbe5
Update the main documentation
rhettinger Jul 26, 2018
0734edd
Add blurb
rhettinger Jul 26, 2018
43471a9
Address Tim's review comments.
rhettinger Jul 27, 2018
3818324
Update argument clinic checksum
rhettinger Jul 27, 2018
8298444
Reuse converted floats rather than converting twice
rhettinger Jul 27, 2018
d785025
Add test for a negative zero input
rhettinger Jul 28, 2018
ee1374c
Test for failed malloc(). Only test inf at the end.
rhettinger Jul 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test for failed malloc(). Only test inf at the end.
  • Loading branch information
@rhettinger
rhettinger committed Jul 28, 2018
commit ee1374c67e1b2cdb071f6387dbf068ce084daf9d
6 changes: 3 additions & 3 deletions Modules/mathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2041,11 +2041,12 @@ math_hypot(PyObject *self, PyObject *args)
double max = 0.0;
double csum = 0.0;
double x, result;
int found_inf = 0;
int found_nan = 0;

n = PyTuple_GET_SIZE(args);
coordinates = (double *) PyObject_Malloc(n * sizeof(double));
if (coordinates == NULL)
return NULL;
for (i=0 ; i<n ; i++) {
item = PyTuple_GET_ITEM(args, i);
x = PyFloat_AsDouble(item);
Expand All @@ -2055,13 +2056,12 @@ math_hypot(PyObject *self, PyObject *args)
}
x = fabs(x);
coordinates[i] = x;
found_inf |= Py_IS_INFINITY(x);
found_nan |= Py_IS_NAN(x);
if (x > max) {
max = x;
}
}
if (found_inf) {
if (Py_IS_INFINITY(max)) {
result = max;
goto done;
}
Expand Down
0