import sys in test_threading_local.py for line 144 #8049
Conversation
__sys__ is used on line 144 but it is never imported.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again for your contribution, we look forward to reviewing it! |
|
CLA signed |
Did you fill your GitHub login in your bugs.python.org account? If yes, it seems like we have to wait until someone review your signature (it's a manual process). |
|
You can check CLA status here: https://check-python-cla.herokuapp.com |
|
check-python-cla says my email address has signed the CLA but my GitHub ID has not but then it says my email address has no bpo account but my GitHub ID does. I have tried several combinations and permutations. cclauss should be both a CLA signatory and a bpo user but check-python-cla does not agree. :-( |
|
What is your bpo username? |
|
cclauss (User30167) |
|
In bpo it still shows that the CLA is not yet received. It might take another US business day. |
|
Thanks, I merged your PR. But I rewrote the commit message. |
|
GH-11450 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit a0bb51e) Co-authored-by: cclauss <cclauss@me.com>
(cherry picked from commit a0bb51e) Co-authored-by: cclauss <cclauss@me.com>
sys is used on line 144 but it is never imported.