8000 Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. by TomFaulkner · Pull Request #8038 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. #8038

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a16862
Update dataclasses.rst
TomFaulkner Jul 1, 2018
78c036c
Update dataclasses.rst
TomFaulkner Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update dataclasses.rst 
Change function to append rather than add lists.
  • Loading branch information
@TomFaulkner
TomFaulkner authored Jul 11, 2018
commit 78c036cfae46ce9cb72f8ce5ff4e779d3844c286
6 changes: 3 additions & 3 deletions Doc/library/dataclasses.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,12 +532,12 @@ Mutable default values
class C:
x = []
def add(self, element):
self.x += element
self.x.append(element)

o1 = C()
o2 = C()
o1.add([1])
o2.add([2])
o1.add(1)
o2.add(2)
assert o1.x == [1, 2]
assert o1.x is o2.x

Expand Down
0