-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-71759: Deprecate using bytes-like objects in builtins. #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-71759: Deprecate using bytes-like objects in builtins. #779
Conversation
Deprecate using bytes-like objects except bytes and bytearray in builtins int(), float(), compile(), eval() and exec().
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericvsmith, @benjaminp and @mdickinson to be potential reviewers. |
@serhiy-storchaka did you still want to pursue this? |
I am not sure. Removing support of general object providing the buffer protocol will simplify the code, but what if somebody needs it? |
@serhiy-storchaka yeah, I don't have a good answer. I guess either ask on python-dev or close this PR to err on the side of backwards-compatibility. |
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
When you're done making the requested changes, leave the comment: |
This PR is stale because it has been open for 30 days with no activity. |
Thanks @hauntsaninja . I think the discussion above between @serhiy-storchaka and @brettcannon is still unresolved. Not sure whether we will go ahead with this PR. |
This PR is stale because it has been open for 30 days with no activity. |
As the years go by, the current behaviour becomes more entrenched and backwards compatibility more important. Let's keep the status quo. I'll close this PR next week if there are no objections. |
Deprecate using bytes-like objects except bytes and bytearray in
builtins int(), float(), compile(), eval() and exec().