8000 gh-71759: Deprecate using bytes-like objects in builtins. by serhiy-storchaka · Pull Request #779 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-71759: Deprecate using bytes-like objects in builtins. #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Mar 23, 2017

Deprecate using bytes-like objects except bytes and bytearray in
builtins int(), float(), compile(), eval() and exec().

Deprecate using bytes-like objects except bytes and bytearray in
builtins int(), float(), compile(), eval() and exec().
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 23, 2017
@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericvsmith, @benjaminp and @mdickinson to be potential reviewers.

@brettcannon
Copy link
Member

@serhiy-storchaka did you still want to pursue this?

@serhiy-storchaka
Copy link
Member Author

I am not sure. Removing support of general object providing the buffer protocol will simplify the code, but what if somebody needs it?

@brettcannon
Copy link
Member

@serhiy-storchaka yeah, I don't have a good answer. I guess either ask on python-dev or close this PR to err on the side of backwards-compatibility.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
@AlexWaygood AlexWaygood changed the title bpo-27572: Deprecate using bytes-like objects in builtins. gh-71759: Deprecate using bytes-like objects in builtins. Nov 9, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Nov 10, 2022
Copy link
Member
@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@github-actions
Copy link
github-actions bot commented Jan 3, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 3, 2023
@hauntsaninja hauntsaninja added awaiting core review and removed awaiting changes stale Stale PR or inactive for long period of time. labels Feb 9, 2023
@iritkatriel
Copy link
Member

Thanks @hauntsaninja .

I think the discussion above between @serhiy-storchaka and @brettcannon is still unresolved. Not sure whether we will go ahead with this PR.

@iritkatriel iritkatriel added the pending The issue will be closed if no feedback is provided label Feb 18, 2023
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 21, 2023
@encukou
Copy link
Member
encukou commented Mar 15, 2024

I guess either ask on python-dev or close this PR to err on the side of backwards-compatibility.

As the years go by, the current behaviour becomes more entrenched and backwards compatibility more important. Let's keep the status quo.

I'll close this PR next week if there are no objections.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Mar 16, 2024
@encukou encukou closed this Mar 19, 2024
@AA-Turner AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0