8000 bpo-30974: fix os.path.samefile docstring with docs by timofurrer · Pull Request #7337 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-30974: fix os.path.samefile docstring with docs #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2019
Merged

bpo-30974: fix os.path.samefile docstring with docs #7337

merged 1 commit into from
Aug 2, 2019

Conversation

timofurrer
Copy link
Contributor
@timofurrer timofurrer commented Jun 2, 2018 •
edited by bedevere-bot
Loading

As proposed in bpo-30974 I've copied the docs of os.path.samefile into it's docstring to prevent confusion about what samefile should do.

https://bugs.python.org/issue30974

srinivasreddy
srinivasreddy approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor
@srinivasreddy srinivasreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timofurrer
Copy link
Contributor Author

Is there something missing from my side?
Is a news entry required for this change?

@zooba zooba added the skip news label Aug 2, 2019
@zooba zooba merged commit 8e568ef into python:master Aug 2, 2019
@miss-islington
Copy link
Contributor

Thanks @timofurrer for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @timofurrer for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2019
@timofurrer @miss-islington
bpo-30974: Change os.path.samefile docstring to match docs (pythonGH-…
5fe3f61 
…7337)

(cherry picked from commit 8e568ef)

Co-authored-by: Timo Furrer <tuxtimo@gmail.com>
@bedevere-bot
Copy link

GH-15086 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2019
@timofurrer @miss-islington
bpo-30974: Change os.path.samefile docstring to match docs (pythonGH-…
267bc75 
…7337)

(cherry picked from commit 8e568ef)

Co-authored-by: Timo Furrer <tuxtimo@gmail.com>
@bedevere-bot
Copy link

GH-15087 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @timofurrer for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @timofurrer and @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e568ef266a2805f9a6042003723d9c050830461 2.7

miss-islington added a commit that referenced this pull request Aug 2, 2019
@miss-islington @timofurrer
bpo-30974: Change os.path.samefile docstring to match docs (GH-7337)
6b83390 
(cherry picked from commit 8e568ef)

Co-authored-by: Timo Furrer <tuxtimo@gmail.com>
miss-islington added a commit that referenced this pull request Aug 2, 2019
@miss-islington @timofurrer
bpo-30974: Change os.path.samefile docstring to match docs (GH-7337)
a49f203 
(cherry picked from commit 8e568ef)

Co-authored-by: Timo Furrer <tuxtimo@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@timofurrer @lisroach
bpo-30974: Change os.path.samefile docstring to match docs (pythonGH-…
eb33f8f 
…7337)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@timofurrer @DinoV
bpo-30974: Change os.path.samefile docstring to match docs (pythonGH-…
334050a 
…7337)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@timofurrer @websurfer5
bpo-30974: Change os.path.samefile docstring to match docs (pythonGH-…
5374436 
…7337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivasreddy srinivasreddy srinivasreddy approved these changes

Assignees

@zooba zooba

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timofurrer @miss-islington @bedevere-bot @srinivasreddy @zooba @the-knights-who-say-ni
0