8000 bpo-33351: Correct struct packing in _tracemalloc.c by emmatyping · Pull Request #6761 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-33351: Correct struct packing in _tracemalloc.c #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

emmatyping
Copy link
Member
@emmatyping emmatyping commented May 11, 2018

This is the first of several patches to add clang-cl compatibility to CPython. (Expect more in the coming days).

While it seems MSVC accepts pragma pack/push after the struct tag, clang-cl does not. AFAIK, pragma pack/push usually should go before the tag. This also adds the same packing to pointer_t (which was packed on GCC but not MSVC) and fixed the comment for pointer_t.

Also, I wasn't sure if a news entry was needed since this is a small internal patch and I couldn't find guidelines for when a news entry should be provided.

https://bugs.python.org/issue33351

@emmatyping
Copy link
Member Author

@zooba this is the issue I mentioned earlier. I'd appreciate your review!

@emmatyping
Copy link
Member Author

Closing in favor of #7680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0