8000 bpo-33211: Change line number of decorated nodes back to def by emmatyping · Pull Request #6460 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-33211: Change line number of decor 8000 ated nodes back to def #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

bpo-33211: Change line number of decorated nodes back to def #6460

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b60b6a6
Change line number of decorated nodes back to def
emmatyping Apr 12, 2018
ae578b0
Whitespace fixes
emmatyping Apr 12, 2018
191bd38
Fix test_dis
emmatyping Apr 12, 2018
da42832
Change fistlineno of decorated nodes in the compiler
emmatyping Apr 12, 2018
649506c
Remove unused var
emmatyping Apr 12, 2018
29b0d60
Fix indentation bug
emmatyping Apr 12, 2018
68b2228
Run patcheck
emmatyping Apr 13, 2018
09d8ab2
Merge remote tracking branch into deflineno
emmatyping Apr 22, 2018
df9fbe2
Change tests back to original state
emmatyping Apr 23, 2018
9840f84
Fix line number in compiler
emmatyping Apr 23, 2018
0842c20
Use unreachable macro
emmatyping Apr 23, 2018
7f4fcdf
Fix silly indentation mistake
emmatyping Apr 23, 2018
e4e7f1a
Test ast line numbers for decorated nodes
emmatyping Apr 24, 2018
a8e747d
Fix true order tests for decorators
emmatyping Apr 24, 2018
3df5862
Fix bad indentation
emmatyping Apr 24, 2018
44a3cd9
Respond to review
emmatyping Apr 24, 2018
afd3b7e
Fix regression with inner decorated nodes
emmatyping Apr 24, 2018
bdc9942
Remove redundant line number setting
emmatyping May 7, 2018
914d0a0
Fix style in compile.c
emmatyping May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test ast line numbers for decorated nodes
  • Loading branch information
@emmatyping
emmatyping committed Apr 24, 2018
commit e4e7f1a20124c59c9725cb86002617531e17b8c9
29 changes: 29 additions & 0 deletions Lib/test/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import dis
import os
import sys
import textwrap
import unittest
import weakref

Expand Down Expand Up @@ -43,12 +44,36 @@ def to_tuple(t):
"def f(**kwargs): pass",
# FunctionDef with all kind of args and docstring
"def f(a, b=1, c=None, d=[], e={}, *args, f=42, **kwargs): 'doc for f()'",
# Decorated FunctionDef
textwrap.dedent("""
@deco
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you use textwrap.dedent() it would clearer if add an indentation of the inner code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the indentation of these fragments.

def f():...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: add a space after :. And maybe use pass?

"""),
# Multiple decorators on a FunctionDef
textwrap.dedent("""
@deco1
@deco2()
def f():...
"""),
# ClassDef
"class C:pass",
# ClassDef with docstring
"class C: 'docstring for class C'",
# ClassDef, new style class
"class C(object): pass",
# Decorated ClassDef
textwrap.dedent("""
@foo
class A:
pass
"""),
# Multiple decorators on a ClassDef
textwrap.dedent("""
@foo1
@bar(4)
class A:
pass
"""),
# Return
"def f():return 1",
# Delete
Expand Down Expand Up @@ -1133,9 +1158,13 @@ def main():
('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [], ('arg', (1, 7), 'args', None), [], [], None, []), [('Pass', (1, 14))], [], None, None)], None),
('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [], None, [], [], ('arg', (1, 8), 'kwargs', None), []), [('Pass', (1, 17))], [], None, None)], None),
('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [('arg', (1, 6), 'a', None), ('arg', (1, 9), 'b', None), ('arg', (1, 14), 'c', None), ('arg', (1, 22), 'd', None), ('arg', (1, 28), 'e', None)], ('arg', (1, 35), 'args', None), [('arg', (1, 41), 'f', None)], [('Num', (1, 43), 42)], ('arg', (1, 49), 'kwargs', None), [('Num', (1, 11), 1), ('NameConstant', (1, 16), None), ('List', (1, 24), [], ('Load',)), ('Dict', (1, 30), [], [])]), [], [], None, 'doc for f()')], None),
('Module', [('FunctionDef', (3, 0), 'f', ('arguments', [], None, [], [], None, []), [('Expr', (3, 8), ('Ellipsis', (3, 8)))], [('Name', (2, 1), 'deco', ('Load',))], None, None)], None),
('Module', [('FunctionDef', (4, 0), 'f', ('arguments', [], None, [], [], None, []), [('Expr', (4, 8), ('Ellipsis', (4, 8)))], [('Name', (2, 1), 'deco1', ('Load',)), ('Call', (3, 0), ('Name', (3, 1), 'deco2', ('Load',)), [], [])], None, None)], None),
('Module', [('ClassDef', (1, 0), 'C', [], [], [('Pass', (1, 8))], [], None)], None),
('Module', [('ClassDef', (1, 0), 'C', [], [], [], [], 'docstring for class C')], None),
('Module', [('ClassDef', (1, 0), 'C', [('Name', (1, 8), 'object', ('Load',))], [], [('Pass', (1, 17))], [], None)], None),
('Module', [('ClassDef', (3, 0), 'A', [], [], [('Pass', (4, 4))], [('Name', (2, 1), 'foo', ('Load',))], None)], None),
('Module', [('ClassDef', (4, 0), 'A', [], [], [('Pass', (5, 4))], [('Name', (2, 1), 'foo1', ('Load',)), ('Call', (3, 1), ('Name', (3, 1), 'bar', ('Load',)), [('Num', (3, 5), 4)], [])], None)], None),
('Module', [('FunctionDef', (1, 0), 'f', ('arguments', [], None, [], [], None, []), [('Return', (1, 8), ('Num', (1, 15), 1))], [], None, None)], None),
('Module', [('Delete', (1, 0), [('Name', (1, 4), 'v', ('Del',))])], None),
('Module', [('Assign', (1, 0), [('Name', (1, 0), 'v', ('Store',))], ('Num', (1, 4), 1))], None),
Expand Down
0