-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-28247: Document Windows executable creation in zipapp #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for fixing the Travis failures - I saw them in the original version, but hadn't had time to work out what was wrong (I hadn't realised that code blocks were formatted as Python by default, doh). I've added a news file. |
Now all I have to do is work out the appropriate merge dance :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's appropriate to review my own change here, but for what it's worth I think this is OK to go now.
I see a lot of core devs approving their own work and sometimes they ping others to ask for a review before merging, so it's totally up to you. |
If you haven't, you should rebuild the doc on your machine and check the html rendering. I cannot review the content; I did not even know about the module until now. Yes, all you have to do is hit the button, fix the title, fix the message, and confirm. The zipapp page, at least the section affected, appears unchanged from 3.6, so if it applies, as it seems to from the issue, let the bot backport it. This usually takes a couple of minutes. All you have to do then is review and approve each backport, and it is a good idea to take at least a quick look, and the merge will be done when CI passes. Or you can wait until CI passes and then hit merge yourself. I find 'approve' easier. |
Thanks @terryjreedy |
GH-6163 is a backport of this pull request to the 3.7 branch. |
) (cherry picked from commit 4be79f2) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
) (cherry picked from commit 4be79f2) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
GH-6164 is a backport of this pull request to the 3.6 branch. |
Patch by Paul Moore.
https://bugs.python.org/issue28247