8000 bpo-28247: Document Windows executable creation in zipapp by csabella · Pull Request #6158 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-28247: Document Windows executable creation in zipapp #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2018

Conversation

csabella
Copy link
Contributor
@csabella csabella commented Mar 20, 2018

Patch by Paul Moore.

https://bugs.python.org/issue28247

@pfmoore
Copy link
Member
pfmoore commented Mar 20, 2018

Thanks for fixing the Travis failures - I saw them in the original version, but hadn't had time to work out what was wrong (I hadn't realised that code blocks were formatted as Python by default, doh). I've added a news file.

@pfmoore
Copy link
Member
pfmoore commented Mar 20, 2018

Now all I have to do is work out the appropriate merge dance :-)

Copy link
Member
@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's appropriate to review my own change here, but for what it's worth I think this is OK to go now.

@csabella
Copy link
Contributor Author

I see a lot of core devs approving their own work and sometimes they ping others to ask for a review before merging, so it's totally up to you.

@terryjreedy
Copy link
Member

If you haven't, you should rebuild the doc on your machine and check the html rendering.

I cannot review the content; I did not even know about the module until now.

Yes, all you have to do is hit the button, fix the title, fix the message, and confirm.

The zipapp page, at least the section affected, appears unchanged from 3.6, so if it applies, as it seems to from the issue, let the bot backport it. This usually takes a couple of minutes. All you have to do then is review and approve each backport, and it is a good idea to take at least a quick look, and the merge will be done when CI passes. Or you can wait until CI passes and then hit merge yourself. I find 'approve' easier.

@pfmoore
Copy link
Member
pfmoore commented Mar 20, 2018

Thanks @terryjreedy

@pfmoore pfmoore merged commit 4be79f2 into python:master Mar 20, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @pfmoore for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6163 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2018
)

(cherry picked from commit 4be79f2)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2018
)

(cherry picked from commit 4be79f2)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

GH-6164 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 20, 2018
(cherry picked from commit 4be79f2)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Mar 20, 2018
(cherry picked from commit 4be79f2)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the issue28247 branch March 21, 2018 12:51
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0