8000 bpo-32968: Modulo and floor division involving Fraction and float should return float by elias6 · Pull Request #5956 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-32968: Modulo and floor division involving Fraction and float should return float #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 27, 2018
Merged

bpo-32968: Modulo and floor division involving Fraction and float should return float #5956

merged 10 commits into from
Aug 27, 2018

Conversation

elias6
Copy link
Contributor
@elias6 elias6 commented Mar 1, 2018 •
edited by bedevere-bot
Loading

This is my initial attempt at a fix for issue 32968.

https://bugs.python.org/issue32968

@elias6
Fraction modulo infinity should behave consistently with other numbers
a4a004c 
This is my initial attempt at a fix for issue 32968.
@mdickinson mdickinson assigned mdickinson and unassigned mdickinson Mar 5, 2018
@mdickinson mdickinson self-requested a review March 5, 2018 18:09
@elias6 elias6 changed the title bpo-32968: Fraction modulo infinity should behave consistently with other numbers Modulo and floor division involving Fraction and float should return float Mar 18, 2018
@elias6
Undo problematic change to fraction math operations
8000
edbea71 
Certain things, like adding math.inf to a fraction, will no longer raise an OverflowError.
@serhiy-storchaka serhiy-storchaka changed the title Modulo and floor division involving Fraction and float should return float bpo-32968: Modulo and floor division involving Fraction and float should return float Mar 26, 2018
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@mdickinson
Revert "Add NEWS entry."
1108ae5 
This reverts commit 4c087de.
@mdickinson
Copy link
Member

Sorry; I added a duplicate Misc/NEWS entry by mistake. I've reverted that change.

mdickinson
mdickinson approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member
@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 393f1ff into python:master Aug 27, 2018
@bedevere-bot
Copy link

@mdickinson: Please replace # with GH- in the commit message next time. Thanks!
81F8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elias6 @the-knights-who-say-ni @mdickinson @bedevere-bot @miss-islington
0