bpo-29762: More use "raise from None". #569
Conversation
This hides unwanted implementation details from tracebacks.
Lib/encodings/punycode.py
Outdated
| @@ -134,7 +134,7 @@ def decode_generalized_number(extended, extpos, bias, errors): | |||
| char = ord(extended[extpos]) | |||
| except IndexError: | |||
| if errors == "strict": | |||
| raise UnicodeError("incomplete punicode string") | |||
| raise UnicodeError("incomplete punicode string") from None | |||
There was a problem hiding this comment.
Done. And there are other bugs in this codec.
Lib/mailbox.py
Outdated
| @@ -201,7 +201,7 @@ def _string_to_bytes(self, message): | |||
| return message.encode('ascii') | |||
| except UnicodeError: | |||
| raise ValueError("String input must be ASCII-only; " | |||
| "use bytes or a Message instead") | |||
| "use bytes or a Message instead") from None | |||
There was a problem hiding this comment.
information about problematic character in the string is lost
|
FYI It's hard to review such change, because each change should be carefully reviewed, whereas the change modifies 31 files. So I decided to skip my turn, maybe review it another day :-) |
Lib/json/tool.py
Outdated
| @@ -40,7 +40,7 @@ def main(): | |||
| obj = json.load(infile, | |||
| object_pairs_hook=collections.OrderedDict) | |||
| except ValueError as e: | |||
| raise SystemExit(e) | |||
| raise SystemExit(e) from None | |||
There was a problem hiding this comment.
I'm note sure about this one.
There was a problem hiding this comment.
Agree. It just doesn't have any visible effect. The original exception is passes to SystemExit, and str(e) is printed to stderr at exit. __cause__ and __context__ are ignored.
|
Except for the one noted in the comment, these all look good. |
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 83.42% 83.46% +0.03%
==========================================
Files 1367 1367
Lines 345769 346382 +613
==========================================
+ Hits 288474 289117 +643
+ Misses 57295 57265 -30
Continue to review full report at Codecov.
|
|
Thank you for your review @wm75 and @rhettinger. |
Bumps [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Changelog](https://github.com/pytest-dev/pytest-asyncio/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-asyncio@v0.18.3...v0.19.0) --- updated-dependencies: - dependency-name: pytest-asyncio dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This hides unwanted implementation details from tracebacks.