8000 bpo-32418: Postfix, raise NotImplementdError and close resources in tests by asvetlov · Pull Request #5052 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-32418: Postfix, raise NotImplementdError and close resources in tests #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2017
Merged

bpo-32418: Postfix, raise NotImplementdError and close resources in tests #5052

merged 1 commit into from
Dec 30, 2017

Conversation

asvetlov
Copy link
Contributor
@asvetlov asvetlov commented Dec 30, 2017 •
edited by bedevere-bot
Loading

Discussed in #4997

AbstractServer.close() and .wait_closed() returned NotImplemented which is obviously wrong and should be replaced by raising NotImplementedError.

https://bugs.python.org/issue32418

@asvetlov asvetlov requested a review from 1st1 as a code owner December 30, 2017 16:16
@asvetlov asvetlov merged commit ffcb4c0 into python:master Dec 30, 2017
@asvetlov asvetlov deleted the bpo-32418 branch December 30, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @1st1 @the-knights-who-say-ni @bedevere-bot
0