-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-32217: Fixed freeze.py for Windows. #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On Windows freeze was never going to work because of this issue. This fix should hopefully make freeze work on Windows again for now.
@bitdancer does this look good to you? |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @csabella: please review the changes made to this pull request. |
@csabella: The PR is now perfect :-) You can merge it if you want. |
GH-12516 is a backport of this pull request to the 3.7 branch. |
Check for sys.abiflags before using since not all platforms have it defined. (cherry picked from commit a7987e7) Co-authored-by: AraHaan <15173749+AraHaan@users.noreply.github.com>
|
I restarted the buildbot and it completed. |
On Windows freeze was never going to work because of this issue. This fix should hopefully make freeze work on Windows again for now.
https://bugs.python.org/issue32217