8000 bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character #4517
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
1b632c1 to
75df15f
Compare
75df15f to
cada3c4
Compare
Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark
Mc Mahon (markm).
Unfortunately Microsoft has deemed it necessary to return the size
of the string without the null termination character but insists
upon the size including it when passing it in. Arggh!
-- Anthony, on the fix
This makes the malloc/free calls more trackable even when more types are added to 8000 MsiSummaryInfoGetProperty.
cada3c4 to
5291f2c
Compare
…e character (pythonGH-4517) Add one char to MsiSummaryInfoGetProperty() output Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark McMahon (markm). (cherry picked from commit 2de576e) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
GH-11738 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @uranusjr and @zooba, I could not cleanly backport this to |
… by one character (pythonGH-4517) Add one char to MsiSummaryInfoGetProperty() output Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark McMahon (markm).. (cherry picked from commit 2de576e) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
GH-11749 is a backport of this pull request to the 2.7 branch. |
… by one character (GH-4517) (GH-11749) Add one char to MsiSummaryInfoGetProperty() output Based on the patch in [bpo-1104](https://bugs.python.org/issue1104) by Anthony Tuininga (atuining) and Mark McMahon (markm) (cherry picked from commit 2de576e) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> https://bugs.python.org/issue1104
Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark Mc Mahon (markm).
https://bugs.python.org/issue1104