8000 [3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230) by taleinat · Pull Request #4253 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230) #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

[3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230) #4253

merged 1 commit into from
Nov 3, 2017

Conversation

taleinat
Copy link
Contributor
@taleinat taleinat commented Nov 3, 2017 •
edited by bedevere-bot
Loading

@taleinat
[3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (
a77fbd2 
pythonGH-4230)

When a single .c file contains several functions and/or methods with
the same name, a safety _METHODDEF GH-define statement is generated
only for one of them.

This fixes the bug by using the full name of the function to avoid
duplicates rather than just the name..
(cherry picked from commit 4f57409)
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Nov 3, 2017
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2017
Merged
@taleinat
Copy link
Contributor Author
taleinat commented Nov 3, 2017

Would it be okay if I merged this myself?

@vstinner vstinner merged commit f8b3f6b into python:3.6 Nov 3, 2017
@vstinner
Copy link
Member
vstinner commented Nov 3, 2017

Thank you for the backport, LGTM and @serhiy-storchaka approved, so I merged it.

Would it be okay if I merged this myself?

Oh, I merged this change before I noticed that you are a core developer and so can merge your own change, sorry. I will let you click you on [Merge] next time ;-)

At least, it doesn't change anything to the ownership, you remain the author of the commit ;-)
A671

@taleinat
Copy link
Contributor Author
taleinat commented Nov 3, 2017

Thanks @Haypo! No worries about the merge, I'm just trying to learn the ropes.

@taleinat taleinat deleted the backport-4f57409-3.6 branch June 25, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taleinat @vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
0