8000 [3.6] bpo-25720: Fix the method for checking pad state of curses WINDOW (GH-4164) by miss-islington · Pull Request #4212 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.6] bpo-25720: Fix the method for checking pad state of curses WINDOW (GH-4164) #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

[3.6] bpo-25720: Fix the method for checking pad state of curses WINDOW (GH-4164) #4212

merged 1 commit into from
Nov 1, 2017

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Nov 1, 2017 •
edited by bedevere-bot
Loading

Modify the code to use ncurses is_pad() instead of checking WINDOW
_flags field. If your platform does not provide the is_pad(), the
existing way that checks the field will be enabled.

Note: This change does not drop support for platforms where do not
have both WINDOW _flags field and is_pad().
(cherry picked from commit 8bc7d63)

https://bugs.python.org/issue25720

@ma8ma @miss-islington
bpo-25720: Fix the method for checking pad state of curses WINDOW (py…
2e259dc 
…thonGH-4164)

Modify the code to use ncurses is_pad() instead of checking WINDOW
_flags field.  If your platform does not provide the is_pad(), the
existing way that checks the field will be enabled.

Note: This change does not drop support for platforms where do not
have both WINDOW _flags field and is_pad().
(cherry picked from commit 8bc7d63)
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Nov 1, 2017
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2017
Merged
@miss-islington
Copy link
Contributor Author

@ma8ma and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .

@serhiy-storchaka serhiy-storchaka merged commit ff6ae4d into python:3.6 Nov 1, 2017
@miss-islington
Copy link
Contributor Author

Thanks, @serhiy-storchaka!

@miss-islington miss-islington deleted the backport-8bc7d63-3.6 branch November 1, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @ma8ma
0