10000 bpo-31629: Add support.SaveSignals by vstinner · Pull Request #4183 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-31629: Add support.SaveSignals #4183

10000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2017
Merged

bpo-31629: Add support.SaveSignals #4183

merged 2 commits into from
Oct 31, 2017

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Oct 31, 2017 •
edited by bedevere-bot
Loading

test_curses now saves/restores signals. On FreeBSD, the curses module
sets handlers of some signals, but don't restore old handlers when
the module is deinitialized.

https://bugs.python.org/issue31629

@vstinner
bpo-31629: Add support.SaveSignals
ec18437 
test_curses now saves/restores signals. On FreeBSD, the curses module
sets handlers of some signals, but don't restore old handlers when
the module is deinitialized.
@vstinner vstinner requested a review from pitrou October 31, 2017 00:23
@serhiy-storchaka serhiy-storchaka added needs backport to 2.7 tests Tests in the Lib/test dir labels Oct 31, 2017
@vstinner vstinner merged commit 19f6830 into python:master Oct 31, 2017
@miss-islington
Copy link
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@vstinner vstinner deleted the save_signals branch October 31, 2017 10:14
@miss-islington
Copy link
Contributor

Sorry, @Haypo, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f68301a1295a9c30d9f28b8f1479cdcccd75aa 3.6

@miss-islington
Copy link
Contributor

Sorry, @Haypo, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f68301a1295a9c30d9f28b8f1479cdcccd75aa 2.7

@bedevere-bot
Copy link

GH-4187 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-4188 is a backport of this pull request to the 2.7 branch.

vstinner added a commit that referenced this pull request Oct 31, 2017
@vstinner
bpo-31629: Add support.SaveSignals (#4183) (#4188)
1d48182 
test_curses now saves/restores signals. On FreeBSD, the curses module
sets handlers of some signals, but don't restore old handlers when
the module is deinitialized.

(cherry picked from commit 19f6830)
vstinner added a commit that referenced this pull request Oct 31, 2017
@vstinner
bpo-31629: Add support.SaveSignals (#4183) (#4187)
41efc40 
test_curses now saves/restores signals. On FreeBSD, the curses module
sets handlers of some signals, but don't restore old handlers when
the module is deinitialized.

(cherry picked from commit 19f6830)
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@vstinner @embray
bpo-31629: Add support.SaveSignals (python#4183)
5758bb7 
test_curses now saves/restores signals. On FreeBSD, the curses module
sets handlers of some signals, but don't restore old handlers when
the module is deinitialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
0