10000 bpo-6986: Add a comment to clarify a test of _json.make_encoder() by orenmn · Pull Request #3789 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-6986: Add a comment to clarify a test of _json.make_encoder() #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2018
Merged

bpo-6986: Add a comment to clarify a test of _json.make_encoder() #3789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
145bbe9
init commit
orenmn Sep 27, 2017
dc1626e
grammar fix
orenmn Sep 27, 2017
0d218f4
fix issue number syntax
orenmn Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
10206
Diff view
Next Next commit
init commit
  • Loading branch information
@orenmn
orenmn committed Sep 27, 2017
commit 145bbe94da3534eb66161bb18dd0612831b86359
2 changes: 2 additions & 0 deletions Lib/test/test_json/test_speedups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ def test(value):

class TestEncode(CTest):
def test_make_encoder(self):
# Issue #6986: The interpreter shouldn't crash in case c_make_encoder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new syntax "bpo-6986" rather than "Issue #6986", it prevents confusion between bugs.python.org bug tracker and GitHub bug tracker ;-)

# received invalid arguments.
self.assertRaises(TypeError, self.json.encoder.c_make_encoder,
(True, False),
b"\xCD\x7D\x3D\x4E\x12\x4C\xF9\x79\xD7\x52\xBA\x82\xF2\x27\x4A\x7D\xA0\xCA\x75",
Expand Down
0