8000 bpo-31592: Fix an assertion failure in Python/ast.c in case of a bad unicodedata.normalize() by orenmn · Pull Request #3767 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-31592: Fix an assertion failure in Python/ast.c in case of a bad unicodedata.normalize() #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2017
Merged

bpo-31592: Fix an assertion failure in Python/ast.c in case of a bad unicodedata.normalize() #3767

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff1fe99
init commit
orenmn Sep 26, 2017
fb73e9f
fix another bug in the C code
orenmn Sep 27, 2017
29f4604
use _PyList_ITEMS()
orenmn Sep 27, 2017
c29d5c0
revert the change. of course, this is a tuple, not a list.
orenmn Sep 27, 2017
cdaead9
completely remove c_normalize_args
orenmn Sep 28, 2017
56c7ead
use _Py_IDENTIFIER()
orenmn Sep 28, 2017
4e0a149
Update 2017-09-26-16-05-04.bpo-31592.IFBZj9.rst
serhiy-storchaka Sep 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use _Py_IDENTIFIER()
  • Loading branch information
@orenmn
orenmn committed Sep 28, 2017
commit 56c7eadc4e344b06d401f21157b5151994126b5f
4 changes: 2 additions & 2 deletions Python/ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,18 +645,18 @@ new_identifier(const char *n, struct compiling *c)
identifier; if so, normalize to NFKC. */
if (!PyUnicode_IS_ASCII(id)) {
PyObject *id2;
_Py_IDENTIFIER(NFKC);
if (!c->c_normalize && !init_normalization(c)) {
Py_DECREF(id);
return NULL;
}
PyObject *form = PyUnicode_FromString("NFKC");
PyObject *form = _PyUnicode_FromId(&PyId_NFKC);
if (form == NULL) {
Py_DECREF(id);
return NULL;
}
PyObject *args[2] = {form, id};
id2 = _PyObject_FastCall(c->c_normalize, args, 2);
Py_DECREF(form);
Py_DECREF(id);
if (!id2)
return NULL;
Expand Down
0