8000 bpo-29679: Implement @contextlib.asynccontextmanager by JelleZijlstra · Pull Request #360 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-29679: Implement @contextlib.asynccontextmanager #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 1, 2017
Merged

bpo-29679: Implement @contextlib.asynccontextmanager #360

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
904e8a8
implement @asynccontextmanager
JelleZijlstra Jan 19, 2017
b3d59f1
add it to __all__
JelleZijlstra Feb 28, 2017
a1d5b3f
add tests (duplicating the @contextmanager ones)
JelleZijlstra Feb 28, 2017
c5b8b43
add docs
JelleZijlstra Mar 1, 2017
ca77cd2
back out ContextDecorator for asynccontextmanager (it doesn't work); …
JelleZijlstra Mar 1, 2017
689f4a5
move asynccontextmanager tests into their own file
JelleZijlstra Mar 1, 2017
299d968
fix when tests are run after test_asyncio
JelleZijlstra Mar 2, 2017
e974d48
add a few more tests
JelleZijlstra Mar 2, 2017
5808a4c
combine duplicate tests
JelleZijlstra Mar 2, 2017
9caa243
additional test for RuntimeError wrapping
JelleZijlstra Mar 2, 2017
64e6908
address 1st1's comments
JelleZijlstra Mar 2, 2017
178433b
clean up "except:" and explain why we can't do that for @contextmanager
JelleZijlstra Mar 3, 2017
6d0dddb
old-style classes, not strings
JelleZijlstra Mar 3, 2017
ad65b4d
add to whatsnew (and alphabetize modules)
JelleZijlstra Mar 3, 2017
737fd0f
add wraps decorator, add to docstring
JelleZijlstra Mar 3, 2017
3fc20a7
unalphabetize whatsnew
JelleZijlstra Mar 3, 2017
06697a8
Merge branch 'master' into asynccontextmanager
1st1 Mar 8, 2017
bb8de0d
Merge branch 'master' into asynccontextmanager
JelleZijlstra Apr 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix when tests are run after test_asyncio
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Mar 2, 2017
commit 299d968dcd469c95bfbb55eb7c9252a3f3feb631
2 changes: 1 addition & 1 deletion Lib/test/test_contextlib_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
def _async_test(func):
"""Decorator to turn an async function into a test case."""
def wrapper(*args, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I know it's just a test, but please add @functools.wraps(func)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a wraps decorator.

loop = asyncio.get_event_loop()
loop = asyncio.new_event_loop()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to close the loop (1), and make sure it's the default loop (2).

Please rewrite to:

loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
try:
    loop.run_until_complete(coro)
finally:
    loop.close()
    asyncio.set_event_loop(None)

coro = func(*args, **kwargs)
return loop.run_until_complete(coro)
return wrapper
Expand Down
0