10000 [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) by mareksuscak · Pull Request #32256 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

8000 [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) #32256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 16, 2022
Merged

[3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) #32256

merged 6 commits into from
May 16, 2022

Conversation

mareksuscak
Copy link
@mareksuscak mareksuscak commented Apr 2, 2022 •
edited by bedevere-bot
Loading

This is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one because the one that superseded it and was implemented in Python 3.10 was larger in scope and technically considered a breaking change.

This PR fixes bpo-34480. I'm adding two unit tests, one of which is based on a test case included in one of the comments and I want to give full credit for writing it to the original author Karthikeyan Singaravelan (xtreak).

https://bugs.python.org/issue34480

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mareksuscak

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@mareksuscak mareksuscak changed the title [3.9] fix bug where match variable is used prior to being defined (GH-17643) [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) Apr 2, 2022
@mareksuscak
Copy link
Author

CLA is now signed. Can take up to 1 business day.

ezio-melotti
ezio-melotti requested changes Apr 6, 2022
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments that point to the original issue and removed some exrta whitespace.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
8000

@mareksuscak
Copy link
Author
mareksuscak commented Apr 6, 2022 •
edited
Loading

@ezio-melotti thank you! I have to leave a comment per bot suggestion, to unblock this PR. Do you want me to add some notes to the NEWS.d/ folder? If so, can you please point me to the right file? I assume this bugfix will land in 3.9.13.

@mareksuscak
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

@ezio-melotti
Copy link
Member

Do you want me to add some notes to the NEWS.d/ folder? If so, can you please point me to the right file?

Yes, a NEWS entry should be added. See https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python

@mareksuscak
Copy link
Author

Alright @ezio-melotti, I've just added a new entry in the NEWS.d folder. Please review and let me know if it looks good to you or if there's anything else that I need to do to get this bugfix merged in.

@mareksuscak
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka requested changes Apr 30, 2022
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ambv
Copy link
Contributor
ambv commented May 16, 2022

We're releasing the last bugfix release of 3.9 today and this PR's been stale for a while on the NEWS entry alone. I'll commandeer the changes to the NEWS entry to land this.

@ambv ambv merged commit 518b238 into python:3.9 May 16, 2022
@ezio-melotti
Copy link
Member

Thanks @mareksuscak for the PR and @ambv for fixing the news entry and merging it -- I missed that this PR was waiting for my review!

@mareksuscak mareksuscak deleted the fix-issue-34480 branch May 17, 2022 14:09
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@mareksuscak @ezio-melotti
@blurb-it @ambv @hello-adam
[3.9] bpo-34480: fix bug where match variable is used prior to being …
180748b 
…defined (pythonGH-17643) (pythonGH-32256)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@kodial kodial mannequin mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
topic-regex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mareksuscak @the-knights-who-say-ni @bedevere-bot @ezio-melotti @ambv @serhiy-storchaka @AlexWaygood
0