10000 bpo-47196: Fix function pointer cast in test_imp by hoodmane · Pull Request #32244 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-47196: Fix function pointer cast in test_imp #32244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to 10000 your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2022
Merged

bpo-47196: Fix function pointer cast in test_imp #32244

merged 2 commits into from
Apr 2, 2022

Conversation

hoodmane
Copy link
Contributor
@hoodmane hoodmane commented Apr 2, 2022 •
edited by miss-islington
Loading

The function PyInit_imp_dummy is declared as void f(PyObject* spec)
but called as void f(void). On wasm targets without the call
trampolines this causes a fatal error.

https://bugs.python.org/issue47196

Automerge-Triggered-By: GH:tiran

@hoodmane
bpo-47196: Fix function pointer cast in test_imp
6debb72 
The function PyInit_imp_dummy is declared as void f(PyObject* spec)
but called as void f(void). On wasm targets without the call
trampolines this causes a fatal error.
@tiran tiran added the skip news label Apr 2, 2022
tiran
tiran approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member
@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. All other modules have an init function without an argument (grep -R -A1 PyMODINIT_FUNC Modules/).

@miss-islington
Copy link
Contributor

@hoodmane: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7000cd7 into python:main Apr 2, 2022
@hoodmane hoodmane mentioned this pull request Apr 3, 2022
Merged
miss-islington pushed a commit that referenced this pull request Apr 3, 2022
@hoodmane
bpo-47196: Fix one more PyInit function signature (GH-32280)
3faa9f7 
I missed one PyInit function in #32244.

Automerge-Triggered-By: GH:tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoodmane @miss-islington @tiran @the-knights-who-say-ni @bedevere-bot
0