8000 bpo-4833: Add ZipFile.mkdir by dignissimus · Pull Request #32160 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-4833: Add ZipFile.mkdir #32160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 5, 2022
Merged

bpo-4833: Add ZipFile.mkdir #32160

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6341b83
Add ZipFile.mkdir
dignissimus Mar 28, 2022
5c441ad
Add news entry
dignissimus Mar 28, 2022
cc3c76e
Remove example zip file
dignissimus Mar 28, 2022
1028df2
Allow directory ordering to vary in tests
dignissimus Mar 28, 2022
702f0d8
Move version directive to end of block
dignissimus Mar 29, 2022
4a93d15
Add fille type flag to ZipFile.mkdir, add ZipFIle.write directory tests
dignissimus Apr 1, 2022
0b4877a
Remove redundant file type mask application
dignissimus Apr 1, 2022
0387bfb
Amend new entry
dignissimus Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant file type mask application
  • Loading branch information
@dignissimus
dignissimus committed Apr 1, 2022
commit 0b4877a43f1b70c6a17d0f51c739be92bf063730
2 changes: 1 addition & 1 deletion Lib/test/test_zipfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2682,7 +2682,7 @@ def test_create_directory_with_write(self):
zf.write(directory, arcname="directory2/")
zinfo = zf.filelist[1]
self.assertEqual(zinfo.filename, "directory2/")
self.assertEqual(zinfo.external_attr, ((0o40000 | mode) << 16) | 0x10)
self.assertEqual(zinfo.external_attr, (mode << 16) | 0x10)

target = os.path.join(TESTFN2, "target")
os.mkdir(target)
Expand Down
0