bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu #3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a definite improvement. A single OptionMenu could work for a unified list of keysets. For themes, I am thinking of a listbox, as with fonts, so one can move around to see the effect of different choices without having the box close. |
|
Why? The change is still needed. |
|
I was reading through the bug tracker and it looked like Spinbox and/or Combobox would be used instead. |
|
Right. I found where I rejected this in its current form, and added more on current uses and replacements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you may want to get rid of Option Menus, but I wanted to show you the ttk version. This was too much of a change to include with the first patch.
https://bugs.python.org/issue30781