8000 bpo-47075: Add shutdown_timeout to multiprocessing BaseManager by vstinner · Pull Request #32112 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-47075: Add shutdown_timeout to multiprocessing BaseManager #32112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

bpo-47075: Add shutdown_timeout to multiprocessing BaseManager #32112

merged 1 commit into from
Apr 19, 2022

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Mar 25, 2022 •
edited by bedevere-bot
Loading

Add an optional keyword 'shutdown_timeout' parameter to the
multiprocessing.BaseManager constructor.

Multiprocessing tests pass test.support.SHORT_TIMEOUT
to BaseManager.shutdown_timeout.

https://bugs.python.org/issue47075

@vstinner
Copy link
Member Author

I don't think that having two separated timeout parameters, one for wait() and a second for join(), is needed. I prefer to have a single value. The process should be able to handle the shutdown command in 1.0 second, if it doesn't, terminate() should terminate it immediately and 1.0 should be enough to wait until the process is killed, no?

cc @pitrou @pablogsal

pitrou
pitrou reviewed Mar 30, 2022
View reviewed changes
Copy link
Member
@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the principle.

@vstinner
Copy link
Member Author
vstinner commented Apr 1, 2022

@pitrou: Would you mind reviewing the updated PR? I completed the doc and changed the behavior: kill the process if it is still alive shutdown_timeout seconds after being terminated.

@vstinner
gh-91231: Add shutdown_timeout to multiprocessing BaseManager
ed8fd6a 
Add an optional keyword 'shutdown_timeout' parameter to the
multiprocessing.BaseManager constructor. Kill the process if
terminate() takes longer than the timeout.

Multiprocessing tests pass test.support.SHORT_TIMEOUT
to BaseManager.shutdown_timeout.
@vstinner vstinner mentioned this pull request Apr 19, 2022
Open
@vstinner vstinner merged commit 061a8bf into python:main Apr 19, 2022
@vstinner vstinner deleted the mp_shutdown_timeout branch April 19, 2022 14:27
@vstinner vstinner mentioned this pull request Apr 21, 2022
Closed
JelleZijlstra added a commit to python/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
multiprocessing: shutdown_timeout param to BaseManager
a0c2fc3 
python/cpython#32112
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 26, 2022
Merged
AlexWaygood pushed a commit to python/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
multiprocessing: add shutdown_timeout param to BaseManager (#7692)
573539b 
python/cpython#32112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @gpshead @pitrou @the-knights-who-say-ni @bedevere-bot
0