[3.7] bpo-47138: Fix documentation build by pinning Jinja version to 3.0.3 #32111
Conversation
|
See my comments on the bug issue. |
There was a problem hiding this comment.
This PR looks good, it only adds a jinja2 pin and doesn't modify the others.
The doc-html preview downloadable at https://github.com/python/cpython/actions/runs/2041354404 looks good too.
Should we use this new bpo number? https://bugs.python.org/issue47138
|
I've updated the commit message with a new ticket number. |
|
@hugovk and @m-aciek, thanks! @m-aciek, perhaps an unnecessary warning but, before doing git pulls on your local repo, you probably will want to do a git reset on your 3.7 and 3.8 branches to remove the commits associated with this and your 3.8 PR as the commits get squashed when merging upstream and so will create an unnecessary merge in your local repo. That's why it's always best to use a unique branch name when creating a PR (like |
|
Yes, I'm sorry for the branch name, it probably made it harder to work with it locally. I used to use git pull --rebase, which should avoid the problem, but thank you for the hint nevertheless. And thank you for the cooperation on the fix! |
https://bugs.python.org/issue47138
https://bugs.python.org/issue45618#msg415979