8000 gh-64490: Fix bugs in argument clinic varargs processing by colorfulappl · Pull Request #32092 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-64490: Fix bugs in argument clinic varargs processing #32092

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Nov 24, 2022
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6793f38
Fix a bug which allows more than one varargs
colorfulappl Mar 24, 2022
6203962
Fix an array index out-of-bound bug
colorfulappl Mar 24, 2022
03be6f9
Fix a kwarg parse bug
colorfulappl Mar 24, 2022
cefe5e9
Merge branch 'main' into unpack_keywords_bugfix
colorfulappl Aug 11, 2022
45bde03
Regenerate clinic.test
colorfulappl Aug 11, 2022
bfc5241
Replace `pre_buffer` to a more descriptive name `nargs`
colorfulappl Aug 11, 2022
0b1523c
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 11, 2022
411ad37
Replace inline literals with double backticks in news
colorfulappl Aug 11, 2022
c6a5171
Rename news
colorfulappl Aug 11, 2022
42f9273
Merge branch 'main' into unpack_keywords_bugfix
colorfulappl Aug 12, 2022
7fdd501
Simplify news
colorfulappl Aug 12, 2022
0aa4be4
Regenerate clinic.test
colorfulappl Aug 12, 2022
bbad2bb
Add test "allow no more than one vararg"
colorfulappl Aug 15, 2022
f7b6662
Merge branch 'main' into unpack_keywords_bugfix
colorfulappl Aug 15, 2022
4fb66ab
Regenerate clinic.test
colorfulappl Aug 15, 2022
8f11765
Modify news
colorfulappl Aug 15, 2022
de5b2a4
Update 2022-08-11-09-58-15.gh-issue-64490.PjwhM4.rst
erlend-aasland Aug 15, 2022
85f98ca
Sphinx syntax/format fix
erlend-aasland Aug 15, 2022
58a3da5
Missing blank line
erlend-aasland Aug 15, 2022
0afce9d
Merge branch 'main' into unpack_keywords_bugfix
colorfulappl Nov 23, 2022
87314ff
Add Argument Clinic functional test cases
colorfulappl Nov 24, 2022
a48971d
Fix bug
colorfulappl Nov 24, 2022
e6a4e13 8000
Do not generate unused `noptargs`
colorfulappl Nov 24, 2022
8592676
Update news
colorfulappl Nov 24, 2022
4c682bf
Update Lib/test/clinic.test
colorfulappl Nov 24, 2022
c3d6b73
Delete unnecessary function doc
colorfulappl Nov 24, 2022
8b26eb8
Merge branch 'main' into unpack_keywords_bugfix
colorfulappl Nov 24, 2022
3f88c54
Rerun make clinic
colorfulappl Nov 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename news
  • Loading branch information
colorfulappl committed Aug 11, 2022
commit c6a51714690a77245d92dffc9856583abf6b82cd
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
Fixes 3 bugs of clinic.py
1. Fix a kwarg parse bug
The calculation of noptargs is incorrect when there is a vararg.
This bug prevents parsed arguments passing to XXXX_impl function.
e.g.
Define function with args::
*args: object
kw: object
and pass kw=1 to the function, the "kw" parameter won't receive the pass in value.
2. Fix an array index out-of-bound bug
Variable "vararg" indicates the index of vararg in parameter list.
While copying kwargs to "buf", the index "i" should not add "vararg", which leads to an out-of-bound bug.
When there are positional args, vararg and keyword args in a function definition, in which case "vararg" > 1, this bug can be triggered.
e.g.
Define function with args::
pos: object
*args: object
kw: object
3. Fix a bug which allows more than one varargs
More than *one* "vararg" should not be allowed.
e.g.
Define function with args::
*vararg1: object
*vararg2: object
Fixes 3 bugs of clinic.py


1. Fix a kwarg parse bug

The calculation of noptargs is incorrect when there is a vararg.
This bug prevents parsed arguments passing to XXXX_impl function.

e.g.
Define function with args::

*args: object
kw: object

and pass kw=1 to the function, the "kw" parameter won't receive the pass in value.


2. Fix an array index out-of-bound bug

Variable "vararg" indicates the index of vararg in parameter list.

While copying kwargs to "buf", the index "i" should not add "vararg", which leads to an out-of-bound bug.

When there are positional args, vararg and keyword args in a function definition, in which case "vararg" > 1, this bug can be triggered.

e.g.
Define function with args::

pos: object
*args: object
kw: object


3. Fix a bug which allows more than one varargs

More than *one* "vararg" should not be allowed.

e.g.
Define function with args::

*vararg1: object
*vararg2: object
0