bpo-44800: unobtrusively rename _PyInterpreterFrame to _Py_frame #32024
ReST is not Markdown
- Loading branch information
commit a8d3c9ec3a5f917ad4e48859f81bc4162f3136b3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| Renamed ``_PyInterpreterFrame`` as ``_Py_frame`` to emphasise its close | ||
| association with ``PyFrameObject`` (they're conceptually the same thing, but | ||
| split into a Python object struct and a C data struct as a performance | ||
| optimisation). | ||
|
|
||
| The ``f_`` prefix has been removed from all ``_Py_frame`` fields that previously | ||
| used it, so the presence or absence of the prefix provides a way to infer | ||
| the exact type of a frame pointer when reading an isolated snippet in a code | ||
| diff. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "conceptually the same thing" mean?
They aren't the same thing. What is the concept that makes them the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same thing that makes it OK to pass both
PyFrameObjectand_PyInterpreterFramestructs to functions that have names starting with_PyFrame: they're Python code evaluation frames either way, but you may be working with the underlying data storage directly, or you may be working with the full refcounted Python object.The difference between the two is mechanical (how their memory allocation is managed) rather than conceptual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your concepts are just that, your concepts. They are highly subjective.
PyFrameObjects and_PyInterpreterFrameare different things. One is a reference counted heap object, the other a stack frame. They have to managed quite differently, to me that means they are "conceptually distinct".