8000 bpo-46785: Fix race condition between `os.stat()` and unlink by itaisteinherz · Pull Request #31858 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46785: Fix race condition between os.stat() and unlink #31858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 2, 2022
Merged

bpo-46785: Fix race condition between os.stat() and unlink #31858

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4b7d59d
Gracefully handle expected errors returned by `FindFirstFileW` in `wi…
itaisteinherz Mar 13, 2022
3c841f3
Add test for bugfix
itaisteinherz Mar 13, 2022
cfc3f2b
Add myself to Misc/ACKS
itaisteinherz Mar 13, 2022
cb4896b
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 13, 2022
b78e22c
Remove resolved TODO
itaisteinherz Mar 13, 2022
918e1ba
Resolve all TODOs
itaisteinherz Mar 13, 2022
d576c3f
Document caught error codes
itaisteinherz Mar 13, 2022
a8fb3f7
Remove duplicate call to `GetLastError()`
itaisteinherz Mar 13, 2022
88fb1fe
CR improvement
itaisteinherz Mar 14, 2022
5ac6f47
CR improvements
itaisteinherz Mar 18, 2022
b212087
Remove unused variable
itaisteinherz Mar 18, 2022
7669397
Terminate test thread at end of test
itaisteinherz Mar 18, 2022
1963993
Add test for race between rmdir and stat
itaisteinherz Mar 18, 2022
4c0f342
Improve bugfix description
itaisteinherz Mar 18, 2022
765194c
Remove new test
itaisteinherz Mar 19, 2022
7d8e146
Merge branch 'main' into bugfix/bpo-46785-os-stat-error-handling
itaisteinherz Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR improvement
  • Loading branch information
@itaisteinherz
itaisteinherz committed Mar 14, 2022
commit 88fb1fe5ef01739304dc1e9ee8e7f2fb93d4292f
15 changes: 6 additions & 9 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2898,22 +2898,19 @@ def test_stat_unlink_race(self):
except OSError:
pass
'''
ignored_errors = (
2, # ERROR_FILE_NOT_FOUND
3, # ERROR_PATH_NOT_FOUND
21, # ERROR_NOT_READY
67, # ERROR_BAD_NET_NAME
)
deadline = time.time() + 5
p = subprocess.Popen([sys.executable, '-c', command, filename])

try:
while time.time() < deadline:
try:
os.stat(filename)
except OSError as e:
if e.winerror not in ignored_errors:
raise
# Note that `ERROR_NOT_READY`, which should also not be
# ignored, results in a `PermissionError`. That is not caught
# here, as only the behavior for `ERROR_FILE_NOT_FOUND` is
# checked in this test.
except FileNotFoundError:
pass
finally:
p.terminate()

Expand Down
0