E5E2 bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() by asvetlov · Pull Request #31840 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() #31840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
Mar 23, 2022
Merged

bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() #31840

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3923c11
bpo-46829: Deprecate passing a message into Future.cancel() and Task.…
asvetlov Mar 12, 2022
55b65f3
Update 2022-03-12-21-07-21.bpo-46829.cpGoPV.rst
asvetlov Mar 12, 2022
55b43fd
Fix notes
asvetlov Mar 12, 2022
3f89aa2
Drop another warning test
asvetlov Mar 12, 2022
ac5e4b1
Merge branch 'main' into deprecate-cancel-msg
asvetlov Mar 13, 2022
ae50f3e
Update docs
asvetlov Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix notes
  • Loading branch information
@asvetlov
asvetlov committed Mar 12, 2022
commit 55b43fd98418ad7b763df13f86ed6c87c8c6ad79
8 changes: 1 addition & 7 deletions Lib/test/test_asyncio/test_taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,10 @@ async def runner():
await asyncio.sleep(0.1)

self.assertFalse(r.done())
with self.assertWarnsRegex(
DeprecationWarning,
"Passing 'msg' argument"
):
r.cancel("test")
r.cancel()
with self.assertRaises(asyncio.CancelledError) as cm:
await r

self.assertEqual(cm.exception.args, ('test',))

self.assertEqual(NUM, 5)

async def test_taskgroup_07(self):
Expand Down
0