8000 bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API by asvetlov · Pull Request #31837 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API #31837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 14, 2022
Merged

bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API #31837

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
50e6b01
bpo-46994: Accept explicit contextvars.Context in asyncio create_task…
asvetlov Mar 12, 2022
e1348e0
Fix context default in C code
asvetlov Mar 12, 2022
8c0aff9
Allow passing context to TaskGroup.create_task()
asvetlov Mar 12, 2022
7a9bded
Fix typo
asvetlov Mar 13, 2022
2a5686c
Merge branch 'main' into task-concept
asvetlov Mar 13, 2022
b375604
Merge branch 'main' into task-concept
asvetlov Mar 13, 2022
6e385ac
Work on
asvetlov Mar 14, 2022
f5816da
Fix C Task impl
asvetlov Mar 14, 2022
1d26ee1
Add taskgroup tests
asvetlov Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow passing context to TaskGroup.create_task()
  • Loading branch information
@asvetlov
asvetlov committed Mar 12, 2022
commit 8c0aff9b74fc1c1d9d0e5874f5a566c694ca00fa
7 changes: 5 additions & 2 deletions Lib/asyncio/taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,15 @@ async def __aexit__(self, et, exc, tb):
me = BaseExceptionGroup('unhandled errors in a TaskGroup', errors)
raise me from None

def create_task(self, coro, *, name=None):
def create_task(self, coro, *, name=None, context=None):
if not self._entered:
raise RuntimeError(f"TaskGroup {self!r} has not been entered")
if self._exiting and self._unfinished_tasks == 0:
raise RuntimeError(f"TaskGroup {self!r} is finished")
task = self._loop.create_task(coro)
if cotext is None:
task = self._loop.create_task(coro)
else:
task = self._loop.create_task(coro, context=context)
tasks._set_task_name(task, name)
task.add_done_callback(self._on_task_done)
self._unfinished_tasks += 1
Expand Down
0