8000 bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId by corona10 · Pull Request #31835 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId #31835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2022
Merged

bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId #31835

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8e4e8
bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId
corona10 Mar 12, 2022
38c95ec
bpo-46987: Remove sys_get_object_id / sys_set_object_id
corona10 Mar 12, 2022
2bdd112
bpo-46987: Address code review
corona10 Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-46987: Remove sys_get_object_id / sys_set_object_id
  • Loading branch information
@corona10
corona10 committed Mar 12, 2022
commit 38c95ec14b66ec50a32407895c15c70066c94022
22 changes: 0 additions & 22 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,6 @@ _PySys_GetAttr(PyThreadState *tstate, PyObject *name)
return value;
}

static PyObject *
sys_get_object_id(PyThreadState *tstate, _Py_Identifier *key)
{
PyObject *sd = tstate->interp->sysdict;
if (sd == NULL) {
return NULL;
}
PyObject *exc_type, *exc_value, *exc_tb;
_PyErr_Fetch(tstate, &exc_type, &exc_value, &exc_tb);
PyObject *value = _PyDict_GetItemIdWithError(sd, key);
/* XXX Suppress a new exception if it was raised and restore
* the old one. */
_PyErr_Restore(tstate, exc_type, exc_value, exc_tb);
return value;
}

static PyObject *
_PySys_GetObject(PyInterpreterState *interp, const char *name)
{
Expand Down Expand Up @@ -132,12 +116,6 @@ sys_set_object(PyInterpreterState *interp, PyObject *key, PyObject *v)
}
}

static int
sys_set_object_id(PyInterpreterState *interp, _Py_Identifier *key, PyObject *v)
{
return sys_set_object(interp, _PyUnicode_FromId(key), v);
}

int
_PySys_SetAttr(PyObject *key, PyObject *v)
{
Expand Down
0