8000 bpo-46745: Fix typo in PositionsIterator by eclipseo · Pull Request #31322 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46745: Fix typo in PositionsIterator #31322

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

bpo-46745: Fix typo in PositionsIterator #31322

merged 2 commits into from
Feb 17, 2022

Conversation

eclipseo
Copy link
Contributor
@eclipseo eclipseo commented Feb 14, 2022 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@eclipseo

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@eclipseo eclipseo changed the title Fix typo in PositionsIterator bpo-46745: Fix typo in PositionsIterator Feb 14, 2022
JelleZijlstra
JelleZijlstra reviewed Feb 14, 2022
View reviewed changes
JelleZijlstra
JelleZijlstra approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this PR in a few days (cc @gvanrossum).

@JelleZijlstra JelleZijlstra self-assigned this Feb 17, 2022
gvanrossum
gvanrossum approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for this.

@JelleZijlstra
Copy link
Member

Yeah I felt like just merging this already would be fine :)

@JelleZijlstra JelleZijlstra merged commit 482a4b6 into python:main Feb 17, 2022
@bedevere-bot
Copy link

@JelleZijlstra: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eclipseo @the-knights-who-say-ni @JelleZijlstra @bedevere-bot @gvanrossum
0