8000 bpo-45393: help() on operator precedence has misleading entries by ZackerySpytz · Pull Request #31246 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-45393: help() on operator precedence has misleading entries #31246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

bpo-45393: help() on operator precedence has misleading entries #31246

merged 1 commit into from
May 19, 2022

Conversation

ZackerySpytz
Copy link
Contributor
@ZackerySpytz ZackerySpytz commented Feb 10, 2022 •
edited by bedevere-bot
Loading

Fix the formatting for "await x" and "not x" in the operator
precedence table.

https://bugs.python.org/issue45393

zware
zware approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member
@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would suggest leaving out the change to Lib/pydoc_data/topics.py. It is regenerated for every release, and keeping it will cause backports to fail.

@zware zware added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 10, 2022
@ZackerySpytz @ambv
bpo-45393: help() on operator precedence has misleading entries
7e77b9e 
Fix the formatting for "await x" and "not x" in the operator
precedence table.
@ambv ambv force-pushed the bpo-45393-await-precedence-docs branch from 5e5a8f6 to 7e77b9e Compare May 19, 2022 14:36
@ambv
Copy link
Contributor
ambv commented May 19, 2022

I rebased and removed changes to Lib/pydoc_data/topics.py.

@ambv ambv added the needs backport to 3.11 only security fixes label May 19, 2022
@ambv ambv merged commit fb082c2 into python:main May 19, 2022
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@ZackerySpytz @miss-islington
bpo-45393: help() on operator precedence has misleading entries (pyth…
19066a9 
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from com
8000
mit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-92965 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@ZackerySpytz @miss-islington
bpo-45393: help() on operator precedence has misleading entries (pyth…
bb40342 
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2022
@bedevere-bot
Copy link

GH-92966 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@ZackerySpytz @miss-islington
bpo-45393: help() on operator precedence has misleading entries (pyth…
1f3b8b8 
…onGH-31246)

Fix the formatting for "await x" and "not x" in the operator
precedence table.
(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 19, 2022
@bedevere-bot
Copy link

GH-92967 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this pull request May 19, 2022
@miss-islington @ZackerySpytz
bpo-45393: help() on operator precedence has misleading entries (GH-3…
fb566ca 
…1246) (GH-92966)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ambv pushed a commit that referenced this pull request May 19, 2022
@miss-islington @ZackerySpytz
bpo-45393: help() on operator precedence has misleading entries (GH-3…
9f7cdb2 
…1246) (GH-92967)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ambv pushed a commit that referenced this pull request May 19, 2022
@miss-islington @ZackerySpytz
bpo-45393: help() on operator precedence has misleading entries (GH-3…
4d1e243 
…1246) (GH-92965)

(cherry picked from commit fb082c2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@m-f-h m-f-h mannequin mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@zware zware zware approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ZackerySpytz @ambv @miss-islington @bedevere-bot @serhiy-storchaka @zware @raghavthind2005 @the-knights-who-say-ni
0