[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) #31030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2022 22:23
(cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between main (3.11) and older versions.
JelleZijlstra
approved these changes
Feb 19, 2022
|
@gvanrossum I'm planning to merge this (a backport of #27642 which you previously merged after my review). The only non-test changes fix a missed error check for |
|
+1. If adding tests never caused us to fix any bugs we’d be doing it wrong. :-) |
|
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to |
|
Thanks; I'll fix the 3.9 backport. |
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Feb 25, 2022
…ythonGH-31030) (cherry picked from commit 3eb3b4f)
|
GH-31586 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
that referenced
this pull request
Mar 2, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ythonGH-31030) (pythonGH-31586) (cherry picked from commit 3eb3b4f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 3eb3b4f)
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no
https://bugs.python.org/issue43853