8000 bpo-46584: remove check for `py2.3` from `ctypes/test_python_api` by sobolevn · Pull Request #31024 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46584: remove check for py2.3 from ctypes/test_python_api #31024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2022
Merged

bpo-46584: remove check for py2.3 from ctypes/test_python_api #31024

merged 2 commits into from
Feb 1, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jan 30, 2022 •
edited by miss-islington
Loading

https://bugs.python.org/issue46584

Automerge-Triggered-By: GH:zware

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jan 30, 2022
@sobolevn sobolevn requested a review from zware January 30, 2022 14:57
arhadthedev
arhadthedev reviewed Jan 30, 2022
View reviewed changes
Lib/ctypes/test/test_python_api.py Outdated
else:
c_py_ssize_t = c_int

c_py_ssize_t = c_size_t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can c_py_ssize_t be removed altogether after it stopped to be a compatibility shim?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 👍

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@arhadthedev
Copy link
Member

@Mariatta Looks like miss-islington needs restoration of push rights for backport branches.

@AlexWaygood
Copy link
Member
AlexWaygood commented Jan 30, 2022 •
edited
Loading

@Mariatta Looks like miss-islington needs restoration of push rights for backport branches.

@arhadthedev that's not the issue (miss-islington is trying to push to the main branch due to the "automerge" label being added). The issue is that Python is currently broken on the main branch, so all PRs are blocked until that's fixed (see https://mail.python.org/archives/list/python-dev@python.org/thread/HU2LH5MX44QZXZ36YS4SOG4ZUPT4E7QT/)

@zware
Copy link
Member
zware commented Jan 31, 2022

Yep, we just need to wait. I was just seeing whether @miss-islington would hold off until the branch was unblocked, or fail; it turned out to be fail (and holding off was probably an unrealistic expectation in the first place :)). We'll get this merged when we can.

@miss-islington miss-islington merged commit 913e340 into python:main Feb 1, 2022
@zware zware added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 1, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-31053 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 1, 2022
@bedevere-bot
Copy link

GH-31054 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@sobolevn @miss-islington
bpo-46584: remove check for py2.3 from ctypes/test_python_api (py…
486b146 
…thonGH-31024)

(cherry picked from commit 913e340)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@sobolevn @miss-islington
bpo-46584: remove check for py2.3 from ctypes/test_python_api (py…
45ecbee 
…thonGH-31024)

(cherry picked from commit 913e340)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington @sobolevn
[3.10] bpo-46584: remove check for py2.3 from `ctypes/test_python_a…
8765b01 
…pi` (GH-31024) (GH-31054)

(cherry picked from commit 913e340)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington @sobolevn
[3.9] bpo-46584: remove check for py2.3 from `ctypes/test_python_ap…
7368ca1 
…i` (GH-31024) (GH-31053)

(cherry picked from commit 913e340)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull 8000 request Jun 2, 2022
@miss-islington @sobolevn @hello-adam
[3.9] bpo-46584: remove check for py2.3 from `ctypes/test_python_ap…
60e4cf7 
…i` (pythonGH-31024) (pythonGH-31053)

(cherry picked from commit 913e340)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@zware zware zware approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sobolevn @miss-islington @arhadthedev @AlexWaygood @zware @bedevere-bot @the-knights-who-say-ni
0