8000 bpo-43224: Implement PEP 646 grammar changes by mrahtz · Pull Request #31018 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-43224: Implement PEP 646 grammar changes #31018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 26, 2022
Merged

bpo-43224: Implement PEP 646 grammar changes #31018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7ecb7ba
bpo-43224: Implement PEP 646 grammar changes
mrahtz Jan 30, 2022
c0531ec
Add tests for del
mrahtz Jan 30, 2022
479c175
Tweak news to better fit in with other PRs
mrahtz Jan 30, 2022
091ceeb
Move error cases into test_syntax
mrahtz Feb 13, 2022
f1c9c77
Add an extra failure test
mrahtz Feb 14, 2022
c8d2534
Add more tests combining slicing with starring
mrahtz Mar 17, 2022
5df1e97
Fix ast representation of slices combined with starring
mrahtz Mar 17, 2022
677a326
Fix broken test in test_unparse
mrahtz Mar 17, 2022
1543785
Add a check_src_roundtrip test for "a[1:2, *a]"
mrahtz Mar 17, 2022
e1ab6ea
fix whitespace (make patchcheck)
JelleZijlstra Mar 23, 2022
18e7fa7
Merge remote-tracking branch 'upstream/main' into pep646-grammar
JelleZijlstra Mar 23, 2022
72dd8b9
Add tests for AST changes
mrahtz Mar 24, 2022
80bb5fa
Fix C unpack
mrahtz Mar 24, 2022
fbfd5b1
Fix typing.get_type_hints on variadic annotation
mrahtz Mar 24, 2022
816098c
Fix typo
mrahtz Mar 24, 2022
8962d26
Remove debug print
mrahtz Mar 25, 2022
973e9cc
Fix potential shadowing in ForwardRef
mrahtz Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move error cases into test_syntax
  • Loading branch information
@mrahtz
mrahtz committed Feb 14, 2022
commit 091ceebdb01c922b6fb67f8277a7bba56b997df1
73 changes: 0 additions & 73 deletions Lib/test/test_pep646_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,61 +250,7 @@
A[(1, 2, 3, 1, 2, 3)]=1
>>> del A[*returns_list(), *returns_list()]; A
delA[(1, 2, 3, 1, 2, 3)]

Slices that should fail

>>> A[:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[:*b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[*b:]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[*b:] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[*b:]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[*b:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[*b:*b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[*b:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[**b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[**b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[**b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

*args annotated as starred expression

>>> def f1(*args: *b): pass
Expand All @@ -327,25 +273,6 @@
Traceback (most recent call last):
...
SyntaxError: invalid syntax

Other uses of starred expressions as annotations should fail

>>> def f6(x: *b): pass
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> def f7(x: *b = 1): pass
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> x: *b
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> x: *b = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
"""

__test__ = {'doctests' : doctests}
Expand Down
72 changes: 72 additions & 0 deletions Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,78 @@
... ...
Traceback (most recent call last):
SyntaxError: positional patterns follow keyword patterns

Uses of the star operator which should fail:

>>> A[:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[:*b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[*b:]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[*b:] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[*b:]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[*b:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[*b:*b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[*b:*b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> A[**b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> A[**b] = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> del A[**b]
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> def f6(x: *b): pass
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> def f7(x: *b = 1): pass
Traceback (most recent call last):
...
SyntaxError: invalid syntax

>>> x: *b
Traceback (most recent call last):
...
SyntaxError: invalid syntax
>>> x: *b = 1
Traceback (most recent call last):
...
SyntaxError: invalid syntax
"""

import re
Expand Down
0