8000 bpo-46449: use strong reference in deepfreeze modules by kumaraditya303 · Pull Request #30987 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46449: use strong reference in deepfreeze modules #30987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2022
Merged

bpo-46449: use strong reference in deepfreeze modules #30987

merged 3 commits into from
Jan 28, 2022

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Jan 28, 2022 •
edited by miss-islington
Loading

https://bugs.python.org/issue46449

Automerge-Triggered-By: GH:tiran

@kumaraditya303 kumaraditya303 mentioned this pull request Jan 28, 2022
Closed
vstinner
vstinner approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that this PR fix https://bugs.python.org/issue46449:

$ ./python -I -X showrefcount -c pass
[8 refs, 0 blocks]

Without the PR:

$ ./python -I -X showrefcount -c pass
[-5 refs, 0 blocks]

vstinner
vstinner reviewed Jan 28, 2022
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment in the _frozen structure (Include/cpython/import.h) to mention explicitly that get_code must return a strong reference?

@vstinner
Copy link
Member

Great! Can you apply skip news (I am not a triager yet)?

Done.

@kumaraditya303
Copy link
Contributor Author

Can you please add a comment in the _frozen structure (Include/cpython/import.h) to mention explicitly that get_code must return a strong reference?

Done!

tiran
tiran requested changes Jan 28, 2022
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

tiran
tiran approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member
@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner vstinner merged commit 5a9e423 into python:main Jan 28, 2022
@vstinner
Copy link
Member

Merged, thanks!

@kumaraditya303 kumaraditya303 deleted the refcnt branch January 28, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kumaraditya303 @vstinner @bedevere-bot @tiran @the-knights-who-say-ni
0