8000 bpo-45735: Promise the long-time truth that `args=list` works by CharlieZhao95 · Pull Request #30982 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-45735: Promise the long-time truth that args=list works #30982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 26, 2022
Merged

bpo-45735: Promise the long-time truth that args=list works #30982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b6231da
Change arguments description in `Thread`.
CharlieZhao95 Jan 27, 2022
76f8d90
Add doc example to use list or tuple as *args*
CharlieZhao95 Jan 27, 2022
d30897c
Add test cases in `Thread` for checking the validity of list *args*.
CharlieZhao95 Jan 27, 2022
b1abac7
Add test cases to check tuple *args*.
CharlieZhao95 Jan 27, 2022
6580a8b
Remove import statement in doc example.
CharlieZhao95 Jan 28, 2022
c973169
Add doc example to threading.rst.
CharlieZhao95 Jan 28, 2022
29393db
Add doc example and test cases for `multiprocessing.Process`.
CharlieZhao95 Jan 29, 2022
7c5e3ca
Add ACKS entry.
CharlieZhao95 Jan 29, 2022
1390ba5
Fix test case in `Process`.
CharlieZhao95 Jan 29, 2022
d641380
Update Doc/library/multiprocessing.rst
CharlieZhao95 Jan 29, 2022
547652d
Update Doc/library/multiprocessing.rst
CharlieZhao95 Jan 29, 2022
702b419
Use `with self.subTest(...)`.
CharlieZhao95 Jan 29, 2022
00ac9d3
Replace `lambda` with `_test()`.
CharlieZhao95 Jan 30, 2022
3efdc5f
Replace `list` with `tuple` in the test_cases and make loop more read…
CharlieZhao95 Jan 30, 2022
8384a45
Remove redundant spaces.
CharlieZhao95 Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use with self.subTest(...).
  • Loading branch information
@CharlieZhao95
CharlieZhao95 committed Jan 30, 2022
commit 702b41929ac698b0bcd2c7de732e4b685ac6d489
5 changes: 3 additions & 2 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,9 @@ def test_args_argument(self):
[tuple_in_list, lambda arg: self.assertEqual(arg, (1,))]
]
for test_case in test_cases:
p = self.Process(target=test_case[1], args=test_case[0])
p.start()
with self.subTest(test_case=test_case):
p = self.Process(target=test_case[1], args=test_case[0])
p.start()

def test_daemon_argument(self):
if self.TYPE == "threads":
Expand Down
5 changes: 3 additions & 2 deletions Lib/test/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,9 @@ def test_args_argument(self):
[tuple_in_list, lambda arg: self.assertEqual(arg, (1,))]
]
for test_case in test_cases:
t = threading.Thread(target=test_case[1], args=test_case[0])
t.start()
with self.subTest(test_case=test_case):
t = threading.Thread(target=test_case[1], args=test_case[0])
t.start()

@cpython_only
def test_disallow_instantiation(self):
Expand Down
0