8000 bpo-46482: add a test for `typing.Annotation.__new__` by sobolevn · Pull Request #30821 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46482: add a test for typing.Annotation.__new__ #30821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

bpo-46482: add a test for typing.Annotation.__new__ #30821

merged 1 commit into from
Feb 1, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jan 23, 2022 •
edited by bedevere-bot
Loading

@sobolevn sobolevn added skip news tests Tests in the Lib/test dir labels Jan 23, 2022
JelleZijlstra
JelleZijlstra reviewed Jan 23, 2022
View reviewed changes
Lib/test/test_typing.py
def test_new(self):
with self.assertRaisesRegex(
TypeError,
'Type Annotated cannot be instantiated',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Type Annotated" is odd wording, it would be clearer as just "Annotated cannot be instantiated".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just copy pasted the existing message. I guess it is out of scope 🙂
Should we open a new issue?

@Fidget-Spinner Fidget-Spinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 23, 2022
@sobolevn
Copy link
Member Author

@Fidget-Spinner any chance to get this merged, please? 🙂

@Fidget-Spinner
Copy link
Member

@sobolevn sorry but I can't, see https://mail.python.org/archives/list/python-dev@python.org/thread/HU2LH5MX44QZXZ36YS4SOG4ZUPT4E7QT/ for the reason :).

@sobolevn
Copy link
Member Author

Oh, this is unexpected! Thanks for letting me know 👍

@Fidget-Spinner Fidget-Spinner changed the title bpo-46482: add a test for typing.Annotation.__new__ add a test for typing.Annotation.__new__ Feb 1, 2022
@Fidget-Spinner Fidget-Spinner changed the title add a test for typing.Annotation.__new__ bpo-46482: add a test for typing.Annotation.__new__ Feb 1, 2022
@Fidget-Spinner Fidget-Spinner merged commit 4c0612a into python:main Feb 1, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@sobolevn @miss-islington
bpo-46482: add a test for typing.Annotation.__new__ (pythonGH-30821)
ff62bbb 
(cherry picked from commit 4c0612a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-31044 is a backport of this pull request to the 3.10 branch.

8000
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@sobolevn @miss-islington
bpo-46482: add a test for typing.Annotation.__new__ (pythonGH-30821)
1c661e3 
(cherry picked from commit 4c0612a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 1, 2022
@bedevere-bot
Copy link

GH-31045 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington
[3.9] bpo-46482: add a test for typing.Annotation.__new__ (GH-30821) (
2532b7c 
GH-31045)

(cherry picked from commit 4c0612a)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Automerge-Triggered-By: GH:Fidget-Spinner
miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington @sobolevn
bpo-46482: add a test for typing.Annotation.__new__ (GH-30821)
6a188d8 
(cherry picked from commit 4c0612a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.10 has failed when building commit 6a188d8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/724/builds/282) and take a look at the build logs.
  4. Check if the failure is related to this commit (6a188d8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/724/builds/282

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 43 sec
  • test_multiprocessing_spawn: 2 min 33 sec
  • test_multiprocessing_forkserver: 1 min 51 sec
  • test_unparse: 1 min 38 sec
  • test_asyncio: 1 min 18 sec
  • test_tokenize: 1 min 10 sec
  • test_logging: 57.8 sec
  • test_lib2to3: 57.4 sec
  • test_capi: 56.6 sec
  • test_io: 47.2 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 10 min 58 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1341, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:997)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
Exception


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_e0ae714c'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_416c473c'

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @hello-adam
[3.9] bpo-46482: add a test for typing.Annotation.__new__ (pythonGH…
e5961cf 
…-30821) (pythonGH-31045)

(cherry picked from commit 4c0612a)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Automerge-Triggered-By: GH:Fidget-Spinner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @Fidget-Spinner @miss-islington @bedevere-bot @JelleZijlstra
0