8000 [3.9] bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) by miss-islington · Pull Request #30779 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

8000 [3.9] bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) #30779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2022
Merged

[3.9] bpo-46442: improve and rename testExceptionCleanupNames (GH-30758) #30779

merged 1 commit into from
Jan 22, 2022

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jan 22, 2022 •
edited
Loading

The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk yellow.dusk1590@fastmail.com

https://bugs.python.org/issue46442

Automerge-Triggered-By: GH:ericvsmith

@yellowdusk1590 @miss-islington
bpo-46442: improve and rename testExceptionCleanupNames (pythonGH-30758)
3229f51 
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 22, 2022
@miss-islington
Copy link
Contributor Author

@yellowdusk1590 and @ericvsmith: Status check is done, and it's a failure ❌ .

@bedevere-bot bedevere-bot mentioned this pull request Jan 22, 2022
Merged
@miss-islington
Copy link
Contributor Author

@yellowdusk1590 and @ericvsmith: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e064af5 into python:3.9 Jan 22, 2022
@miss-islington miss-islington deleted the backport-82c5322-3.9 branch January 22, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @ericvsmith @the-knights-who-say-ni @bedevere-bot @yellowdusk1590
0