8000 bpo-46425: fix direct invocation of `test_sqlite3` by sobolevn · Pull Request #30676 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46425: fix direct invocation of test_sqlite3 #30676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2022
Merged

bpo-46425: fix direct invocation of test_sqlite3 #30676

merged 1 commit into from
Jan 22, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jan 18, 2022 •
edited by bedevere-bot
Loading

This fixes ./python.exe Lib/test/test_sqlite3/... tests.
Without this change it fails:

» ./python.exe Lib/test/test_sqlite3/test_transactions.py 
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_sqlite3/test_transactions.py", line 26, in <module>
    from .test_dbapi import memory_database
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: attempted relative import with no known parent package

Refs #30666
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
@sobolevn sobolevn added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip news labels Jan 18, 2022
@zware zware requested a review from erlend-aasland January 18, 2022 22:43
@zware zware changed the title bpo-46425: fix direct invokation of test_sqlite3 bpo-46425: fix direct invocation of test_sqlite3 Jan 18, 2022
erlend-aasland
erlend-aasland approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@erlend-aasland
Copy link
Contributor
erlend-aasland commented Jan 18, 2022 •
edited
Loading

This should not be backported. The sqlite3 test suite has changed a lot since 3.10 and 3.9. I don't think this would apply cleanly at all. IMO, I don't think it is worth backporting it.

@erlend-aasland erlend-aasland removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 18, 2022
@asvetlov asvetlov merged commit 55f4ec4 into python:main Jan 22, 2022
@sobolevn sobolevn mentioned this pull request Apr 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sobolevn @erlend-aasland @asvetlov @JelleZijlstra @kumaraditya303 @the-knights-who-say-ni @bedevere-bot
0