bpo-46398: posixshmem module shm_rename freebsd support. #30621
Conversation
36de652 to
4bec161
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
This comment was marked as outdated.
This comment was marked as outdated.
|
|
||
| Rename a shared memory object. | ||
|
|
||
| Remove a shared memory object and relink to another path |
There was a problem hiding this comment.
| Remove a shared memory object and relink to another path | |
| Remove a shared memory object and relink to another path. |
| _posixshmem.shm_rename | ||
| path_from: unicode | ||
| path_to: unicode | ||
| flags: int |
There was a problem hiding this comment.
| flags: int | |
| flags: int | |
| / |
I think it was mistake to make parameters keyword-or-positional in other functions. It is better to make them positional-only, it will help if we decide to rename parameters.
Lib/multiprocessing/shared_memory.py
Outdated
| With the SHM_RENAME_NOREPLACE flag, an error will be returned | ||
| if the new name exists. | ||
| """ | ||
| if platform.system() != "FreeBSD": |
There was a problem hiding this comment.
It is better to use hasattr(). If in future shm_rename() be added on other platforms, it will automatically add support of SharedMemory.rename().
| const char *from = PyUnicode_AsUTF8(path_from); | ||
| const char *to = PyUnicode_AsUTF8(path_to); | ||
| if (from == NULL || to == NULL) { | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
This function has the same bug as shm_open() and shm_unlink() (see #115886). Please check the names for embedded null characters.
Lib/multiprocessing/shared_memory.py
Outdated
| if newname: | ||
| newname = "/" + newname if self._prepend_leading_slash else newname | ||
| r = _posixshmem.shm_rename(self._name, newname, flags) | ||
| if r == None: |
There was a problem hiding this comment.
It is always true, isn't?
| if platform.system() != "FreeBSD": | ||
| raise OSError("Unsupported operation on this platform") | ||
|
|
||
| if newname: |
There was a problem hiding this comment.
So it simply returns False if newname is empty and returns True otherwise? Why add such check in this method?
| With the SHM_RENAME_NOREPLACE flag, an error will be returned | ||
| if the new name exists. | ||
| """ | ||
| if !platform.hasattr("shm_rename"): |
There was a problem hiding this comment.
| if !platform.hasattr("shm_rename"): | |
| if not platform.hasattr("shm_rename"): |
There was a problem hiding this comment.
What is this platform.hasattr() function? Where does it come from?
https://bugs.python.org/issue46398