8000 bpo-46362: Ensure ntpath.abspath() calls Windows API by neonene · Pull Request #30571 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46362: Ensure ntpath.abspath() calls Windows API #30571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2022
Merged

bpo-46362: Ensure ntpath.abspath() calls Windows API #30571

merged 3 commits into from
Jan 13, 2022

Conversation

neonene
Copy link
Contributor
@neonene neonene commented Jan 13, 2022 •
edited by bedevere-bot
Loading

This also makes ntpath.abspath()/getpath_abspath() follow normpath(),　since some WinAPIs such as PathCchSkipRoot() require backslashed paths.

https://bugs.python.org/issue46362

@neonene
Ensure ntpath.abspath() calls Windows API
1fe6039 
This also makes ntpath.abspath()/getpath_abspath() follow normpath(),
since some WinAPIs such as PathCchSkipRoot() require backslashed paths.
zooba
zooba approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member
@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll want a NEWS entry for this, but it doesn't have to go into a lot of detail on the implementation. Can just explain the user-visible problem that was resolved.

@neonene
Copy link
Contributor Author
neonene commented Jan 13, 2022

Done. Thanks for reviewing.

@zooba zooba merged commit d4e64cd into python:main Jan 13, 2022
@neonene neonene deleted the abspath branch January 13, 2022 23:39
@nineteendo nineteendo mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neonene @zooba @the-knights-who-say-ni @bedevere-bot
0