8000 bpo-46262: cover error path in `enum.Flag._missing_` by sobolevn · Pull Request #30408 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46262: cover error path in enum.Flag 8000 ._missing_ #30408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2022
Merged

bpo-46262: cover error path in enum.Flag._missing_ #30408

merged 3 commits into from
Jan 5, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Jan 4, 2022 •
edited by bedevere-bot
Loading

This path is now covered:

cpython/Lib/enum.py

Lines 1222 to 1225 in 31e43cb

if not isinstance(value, int):
raise ValueError(
"%r is not a valid %s" % (value, cls.__qualname__)
)

https://bugs.python.org/issue46262

@sobolevn sobolevn requested a review from ethanfurman as a code owner January 4, 2022 22:40
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 4, 2022
AlexWaygood
AlexWaygood reviewed Jan 4, 2022
View reviewed changes
@ethanfurman @AlexWaygood
Update Misc/NEWS.d/next/Tests/2022-01-05-01-38-45.bpo-46262.MhiLWP.rst
5daef2c 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ethanfurman ethanfurman merged commit 91bc6f9 into python:main Jan 5, 2022
@sobolevn
Copy link
Member Author
sobolevn commented Jan 5, 2022 •
edited
Loading

Thanks everyone!

P.S. @ethanfurman would you be so kind to also review one more my enum.py PR? #30357 🙂

(I've also found several other untested features, so new PRs are incoming) 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @ethanfurman @AlexWaygood @the-knights-who-say-ni @bedevere-bot
0