10000 Fix missing "," in the documentation of Executor Objects by philipp-classen · Pull Request #30404 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix missing "," in the documentation of Executor Objects #30404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2022
Merged

Fix missing "," in the documentation of Executor Objects #30404

merged 1 commit into from
Jan 4, 2022

Conversation

philipp-classen
Copy link
Contributor
@philipp-classen philipp-classen commented Jan 4, 2022 •
edited by miss-islington
Loading

No issue, only a fixed typo in the documentation.

Automerge-Triggered-By: GH:Mariatta

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jan 4, 2022
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@philipp-classen

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Mariatta
Mariatta approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member
@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta merged commit f404e26 into python:main Jan 4, 2022
@miss-islington
Copy link
Contributor

Thanks @philipp-classen for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2022
@philipp-classen @miss-islington
Fix missing "," in the documentation of Executor Objects (pythonGH-30404
4197efb 
)

(cherry picked from commit f404e26)

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>
@bedevere-bot
Copy link

GH-30405 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2022
@philipp-classen @miss-islington
Fix missing "," in the documentation of Executor Objects (pythonGH-30404
1b13c95 
)

(cherry picked from commit f404e26)

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 4, 2022
@bedevere-bot
Copy link

GH-30406 is a backport of this pull request to the 3.9 branch.

Mariatta pushed a commit that referenced this pull request Jan 4, 2022
@miss-islington @philipp-classen
Fix missing "," in the documentation of Executor Objects (GH-30404)
f902d88 
(cherry picked from commit f404e26)

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>
@Mariatta
Copy link
Member
Mariatta commented Jan 4, 2022

Thanks for the fix. Since this is a trivial one-letter change, I bypassed the CLA requirement. However, if you plan on continuing to contribute, please sign the CLA.

Mariatta pushed a comm 844B it that referenced this pull request Jan 4, 2022
@miss-islington @philipp-classen
Fix missing "," in the documentation of Executor Objects (GH-30404)
289a32b 
(cherry picked from commit f404e26)

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>

Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@philipp-classen @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @AlexWaygood
0