8000 bpo-26510: Allow argparse add_subparsers to take `required` kwarg. by asottile · Pull Request #3027 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-26510: Allow argparse add_subparsers to take required kwarg. #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2017
Merged

bpo-26510: Allow argparse add_subparsers to take required kwarg. #3027

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46282df
Allow argparse add_subparsers to take `required` kwarg.
asottile Aug 8, 2017
dede844
Subparsers are required by default.
asottile Aug 8, 2017
bb9b7e7
Add news and update docs.
asottile Sep 19, 2017
28bfe64
Minor tweaks
merwok Sep 20, 2017
b3cbad6
rewrite news
merwok Sep 20, 2017
fe5feb0
Make explicit that there is a new param
merwok Sep 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor tweaks
  • Loading branch information
@merwok @asottile
merwok authored and asottile committed Sep 20, 2017
commit 28bfe647ab91a617f8c032fcc74891faacfa0650
4 changes: 3 additions & 1 deletion Lib/test/test_argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,7 +1911,8 @@ def _test_required_subparsers(self, parser):
# Should parse the sub command
ret = parser.parse_args(['run'])
self.assertEqual(ret.command, 'run')
# Should error when missing the command

# Error when the command is missing
self.assertArgumentParserError(parser.parse_args, ())

def test_required_subparsers_via_attribute(self):
Expand All @@ -1937,6 +1938,7 @@ def test_optional_subparsers(self):
parser = ErrorRaisingArgumentParser()
subparsers = parser.add_subparsers(dest='command', required=False)
subparsers.add_parser('run')
# No error here
ret = parser.parse_args(())
self.assertIsNone(ret.command)

Expand Down
0