bpo-31130: Fix test_idle reference leaks #3014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_configdialog: * VarTraceTest.setUp() now calls tracers.detach() before calling tracers.clear(). * tearDownModule() now calls tracers.clear() after calling tracers.detach().
|
LGTM. But I think the VarTraceTest use the wrong tracers, it should create its tracers, not using |
|
I somehow did not notice this PR when I read the issue. I independently noticed that VarTraceTest also leaked and concluded the same thing Louie did -- better to create a separate instance and delete it. The result is a merge conflict between the two patches, so I am closing this in favor of #3016, which revises and improves VarTraceTest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_configdialog:
tracers.clear().
tracers.detach().
https://bugs.python.org/issue31130