8000 bpo-45831: _Py_DumpASCII() uses a single write() call if possible by vstinner · Pull Request #29596 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-45831: _Py_DumpASCII() uses a single write() call if possible #29596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

bpo-45831: _Py_DumpASCII() uses a single write() call if possible #29596

merged 1 commit into from
Nov 17, 2021

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Nov 17, 2021 •
edited by bedevere-bot
Loading

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.

https://bugs.python.org/issue45831

@ambv ambv changed the title _Py_DumpASCII() uses a single write() call if possible bpo-45831: _Py_DumpASCII() uses a single write() call if possible Nov 17, 2021
@vstinner
bpo-45831: _Py_DumpASCII() uses a single write() call if possible
4592a7f 
If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
@ambv ambv merged commit b919d81 into python:main Nov 17, 2021
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 17, 2021
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2021
@vstinner @miss-islington
bpo-45831: _Py_DumpASCII() uses a single write() call if possible (py…
33ece1b 
…thonGH-29596)

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
(cherry picked from commit b919d81)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 17, 2021
@bedevere-bot
Copy link

GH-29597 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2021
@vstinner @miss-islington
bpo-45831: _Py_DumpASCII() uses a single write() call if possible (py…
1ad5807 
…thonGH-29596)

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
(cherry picked from commit b919d81)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 17, 2021
@bedevere-bot
Copy link

GH-29598 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this pull request Nov 17, 2021
@miss-islington @vstinner
bpo-45831: _Py_DumpASCII() uses a single write() call if possible (GH…
4ffde90 
…-29596) (GH-29598)

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
(cherry picked from commit b919d81)

Co-authored-by: Victor Stinner <vstinner@python.org>
ambv pushed a commit that referenced this pull request Nov 17, 2021
@miss-islington @vstinner
bpo-45831: _Py_DumpASCII() uses a single write() call if possible (GH…
ac89f8c 
…-29596) (GH-29597)

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
(cherry picked from commit b919d81)

Co-authored-by: Victor Stinner <vstinner@python.org>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@vstinner @remykarem
bpo-45831: _Py_DumpASCII() uses a single write() call if possible (py…
93ad62d 
…thonGH-29596)

If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
@vstinner vstinner deleted the traceback branch December 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstinner @miss-islington @bedevere-bot @erlend-aasland @ambv @the-knights-who-say-ni
0