8000 [3.10] bpo-45655: Add "relevant PEPs" section to ``typing`` documentation (GH-29280) by miss-islington · Pull Request #29290 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-45655: Add "relevant PEPs" section to typing documentation (GH-29280) #29290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-45655: Add "relevant PEPs" section to typing documentation (GH-29280) #29290

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Oct 28, 2021 •
edited by bedevere-bot
Loading

The list of PEPs at the top of the documentation for the typing module has
become too long to be readable. This PR proposes presenting this
information in a more structured and readable way by adding a new "relevant
PEPs" section to the typing docs.

Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 03db1bb)

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

https://bugs.python.org/issue45655

@AlexWaygood @miss-islington
bpo-45655: Add "relevant PEPs" section to typing documentation (p…
ed836d7 
…ythonGH-29280)

The list of PEPs at the top of the documentation for the ``typing`` module has
become too long to be readable. This PR proposes presenting this
information in a more structured and readable way by adding a new "relevant
PEPs" section to the ``typing`` docs.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 03db1bb)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 28, 2021
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Oct 28, 2021
Merged
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ❌ .

@ambv
Copy link
Contributor
ambv commented Oct 28, 2021

Looks like you need to move typing positions Doc/tools/susp-ignored.csv. I recommend just removing the line numbers.

@ambv
Copy link
Contributor
ambv commented Oct 28, 2021

You should be able to check out this PR with gh pr checkout 29290 if you get the Github CLI tool. It's very handy for this sort of thing.

@AlexWaygood
Copy link
Member
8000

You should be able to check out this PR with gh pr checkout 29290 if you get the Github CLI tool. It's very handy for this sort of thing.

I was able to checkout the PR, but not push to Miss Islington's branch, so I created a new PR for the 3.10 branch here: #29302

@miss-islington miss-islington deleted the backport-03db1bb-3.10 branch October 28, 2021 23:39
@Fidget-Spinner
Copy link
Member

Closed in favor of GH-29302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @ambv @AlexWaygood @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot
0